Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix index build for literal "\"^^"@en #371

Merged
merged 1 commit into from Mar 23, 2021
Merged

Fix index build for literal "\"^^"@en #371

merged 1 commit into from Mar 23, 2021

Conversation

ckorzen
Copy link
Member

@ckorzen ckorzen commented Dec 14, 2020

Building the index crashes for the full RDF dump of DBpedia, the exact error message is:

ERROR: BAD INPUT STRING (No ':' in non-URL ValueLiteral "\"^^"@en; in /app/src/index/../util/Conversions.h, line 130, function std::__cxx11::string ad_utility::convertValueLiteralToIndexWord(const string&))

The reason is that the dump contains the literal "\"^^"@en, which is mistakenly processed as a literal with a XSD datatype. Obviously, it should be processed as a language-tagged string.

Copy link
Member

@joka921 joka921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry that this took so long.

This whole "XSD-VALUE-Business" Is very broken.

@joka921 joka921 merged commit e28ad52 into master Mar 23, 2021
@hannahbast hannahbast deleted the isXsdValue-fix branch April 20, 2022 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants