Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused toString method in ParsedQuery #378

Closed
joka921 opened this issue Apr 7, 2021 · 0 comments · Fixed by #1317
Closed

Unused toString method in ParsedQuery #378

joka921 opened this issue Apr 7, 2021 · 0 comments · Fixed by #1317
Labels
cleanup Non functional change for better maintainability or portability

Comments

@joka921
Copy link
Member

joka921 commented Apr 7, 2021

The ParsedQuery class has a toString method, that is recursively defined for all types.
It is however never used and not needed (only reference is a trivial test that can be done much easier).
We should get rid of this Code for good.
@joka921 joka921 added the cleanup Non functional change for better maintainability or portability label Apr 7, 2021
@RobinTF RobinTF mentioned this issue Apr 2, 2024
Merged
joka921 pushed a commit that referenced this issue Apr 2, 2024
@RobinTF
Remove unused functions from the GraphPattern class (#1317)
25449d2 
Fixes #378
Remove the `toString` function from the `GraphPattern` and `GraphPatternOperation` class. These functions were only used for printing in case of test failures and their implementation was not useful and poorly maintained anyway.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup Non functional change for better maintainability or portability
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unused functions from the GraphPattern class RobinTF/qlever
1 participant
@joka921