Make getHTTPRequest() at least somewhat sane #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code really needs replacement with a proper HTTP library but for now at least fix the most glaring issues, including: - Add a TODO to get this removed - Don't busy wait with recv(…, MSG_DONTWAIT) for no gain over blocking and 100% CPU use - Actually extract the headers instead of leaving them empty - Just use a string instead of a std::ostringstream and converting back and forth - Don't use NULL terminated string APIs when we have nice ones - Add some useful comments on what the ifs actually test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code really needs replacement with a proper HTTP library but for now at
least fix the most glaring issues, including:
CPU use