Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make getHTTPRequest() at least somewhat sane #48

Merged
merged 1 commit into from
Apr 17, 2018
Merged

Make getHTTPRequest() at least somewhat sane #48

merged 1 commit into from
Apr 17, 2018

Commits on Apr 17, 2018

  1. Make getHTTPRequest() at least somewhat sane

    This code really needs replacement with a proper HTTP library but for now at
    least fix the most glaring issues, including:
    
    - Add a TODO to get this removed
    - Don't busy wait with recv(…, MSG_DONTWAIT) for no gain over blocking and 100%
      CPU use
    - Actually extract the headers instead of leaving them empty
    - Just use a string instead of a std::ostringstream and converting back and forth
    - Don't use NULL terminated string APIs when we have nice ones
    - Add some useful comments on what the ifs actually test
    niklas88 committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    0d66265 View commit details
    Browse the repository at this point in the history