New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some isolated files from the Expression PR for easier review #480
Some isolated files from the Expression PR for easier review #480
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1-1 with Johannes, some changes + will review again
2a764bf
to
8e9d846
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another quick 1-1 with Johannes.
Add the switch + rename isValidGetter to isValidValueGetter
- Added switch instead of if-else - Rename IsValidGetter -> IsValidValueGetter - Added clone-method for LimitedVector.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another quick 1-1 with Johannes, thanks!
No description provided.