Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some isolated files from the Expression PR for easier review #480

Merged
merged 7 commits into from
Sep 28, 2021
Merged

Some isolated files from the Expression PR for easier review #480

merged 7 commits into from
Sep 28, 2021

Commits on Sep 27, 2021

  1. some separate Files a a preliminary for SparqlExpressions

    @joka921
    joka921 committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    f9b7d83 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2021

  1. Applied Hannah's Review

    @joka921
    joka921 committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    9e4cf51 View commit details
    Browse the repository at this point in the history

  2. clang-format.

    @joka921
    joka921 committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    6f27167 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into f.someFilesForSparqlExpressions

    @joka921
    joka921 committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    8e9d846 View commit details
    Browse the repository at this point in the history

  4. Updates for the value getters.

    @joka921
    joka921 committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    e1c3d63 View commit details
    Browse the repository at this point in the history

  5. Last round of reviews: 

    - Added switch instead of if-else
- Rename IsValidGetter -> IsValidValueGetter
- Added clone-method for LimitedVector.
    @joka921
    joka921 committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    3574c23 View commit details
    Browse the repository at this point in the history

  6. Added Hashing for some types and an additional check for a non-exhaus… 

    …tive switch.
    @joka921
    joka921 committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    e8c606e View commit details
    Browse the repository at this point in the history