Simplify how strings are read from DocsDB and ExternalVocabulary #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sadly until C++17 std::string::data() returns a const pointer and thus we need to resort to the front() trick. We can fix this once C++17 is out. NOTE: This is legal only due to the contiguous memory guarantee introduced in C++11 see also: http://stackoverflow.com/questions/33124479/does-stdstring-need-to-store-its-character-in-a-contiguous-piece-of-memory
|
Hi Niklas, thanks for the patch. Looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the words in the external vocabulary and the docs in DocsDB are turned into std::strings by creating a temporary heap allocated char array and constructing a std::string from that.
Instead we can use the contiguous memory guarantee introduced in C++11 to read directly into a string of the right size. When C++17 comes along we can even change this to use non-const .data() to make it cleaner.
While we are add it fix a comment.