Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify how strings are read from DocsDB and ExternalVocabulary #6

Merged
merged 3 commits into from
Apr 28, 2017
Merged

Simplify how strings are read from DocsDB and ExternalVocabulary #6

merged 3 commits into from
Apr 28, 2017

Commits on Apr 27, 2017

  1. Fix comment: A returned string object is an rvalue

    @niklas88
    niklas88 committed Apr 27, 2017
    Configuration menu
    Copy the full SHA
    8bc4a69 View commit details
    Browse the repository at this point in the history

  2. Simplify reading strings from DocsDB/Ex..Vocabulary 

    Sadly until C++17 std::string::data() returns a const pointer and thus
we need to resort to the front() trick. We can fix this once C++17
is out.

NOTE: This is legal only due to the contiguous memory guarantee
introduced in C++11 see also:

http://stackoverflow.com/questions/33124479/does-stdstring-need-to-store-its-character-in-a-contiguous-piece-of-memory
    @niklas88
    niklas88 committed Apr 27, 2017
    Configuration menu
    Copy the full SHA
    9e2f35c View commit details
    Browse the repository at this point in the history

  3. Add TODO for C++17 non-const data()

    @niklas88
    niklas88 committed Apr 27, 2017
    Configuration menu
    Copy the full SHA
    0593e64 View commit details
    Browse the repository at this point in the history