Refactor workflows + revert to standard apt
#1185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1185 +/- ##
==========================================
+ Coverage 84.19% 84.21% +0.02%
==========================================
Files 305 305
Lines 28779 28779
Branches 3425 3425
==========================================
+ Hits 24230 24236 +6
+ Misses 3133 3130 -3
+ Partials 1416 1413 -3 ☔ View full report in Codecov by Sentry. |
hannahbast
requested changes
Dec 11, 2023
hannahbast
approved these changes
Dec 11, 2023
hannahbast
changed the title
apt
|
Kudos, SonarCloud Quality Gate passed!
|
schlegan
pushed a commit
to schlegan/qlever
that referenced
this pull request
Dec 14, 2023
1. For a while now, we used `apt-spy` because `apt` was not working reliably within GitHub's workflows. Recently, it was `apt-spy` that was unreliable and so we are reverting back to `apt` 2. Use the occasion to factor out separate `action.yml` "sub"-workflow for installing a compiler on Ubuntu and for installing dependencies on Ubuntu, which are used at various places in our workflows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apt-spybecauseaptwas not working reliably within GitHub's workflows. Recently, it wasapt-spythat was unreliable and so we are reverting back toaptaction.yml"sub"-workflow for installing a compiler on Ubuntu and for installing dependencies on Ubuntu, which are used at various places in our workflows