Actually use Operation::knownEmptyResult fixes #42 #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklas88
requested review from
joka921
and removed request for
floriankramer
This would make PR #108 superflous but I don't think that change hurts and it does feel a bit risky to estimate zero sized results.
joka921
approved these changes
Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
QueryExecutionTreeso that it actually calls theOperation::knownEmptyResult()methods for its ownknownEmptyResult(). I also moved the optimization of computing the result of a scan if it's simple to its owngetSizeEstimate().This would make PR #108 superflous but I don't think that change hurts and it does feel a bit risky to estimate zero sized results.
Also I still need to add a test case on scientists but it's not super easy to trigger as only
Filteris currently known to create0size estimates and only with appropriately sized inputs.