Provide framework for generic lazily evaluated operation results #1350
+1,595
−199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinTF
commented
May 18, 2024
RobinTF
commented
May 18, 2024
| result._resultPointer->resultTable()->idTable().numColumns(); | ||
| LOG(DEBUG) << "Computed result of size " << resultNumRows << " x " | ||
| << resultNumCols << std::endl; | ||
| } |
There was a problem hiding this comment.
Does this debug message provide any real benefit to make it worth somehow incorporating it into lazily evaluated operations?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1350 +/- ##
==========================================
- Coverage 88.89% 88.06% -0.84%
==========================================
Files 327 329 +2
Lines 28974 29430 +456
Branches 3210 3271 +61
==========================================
+ Hits 25756 25917 +161
- Misses 2066 2331 +265
- Partials 1152 1182 +30 ☔ View full report in Codecov by Sentry. |
joka921
pushed a commit
that referenced
this pull request
May 23, 2024
This PR contains all the changes from the infrastructure for lazy operation evaluation (#1350) that are simple and repetitive, but touch many files. In particular: * Rename the `ResultTable` class to `Result` (a TODO suggested by @hannahbast some time ago). * Add a new parameter `bool requestLaziness` to `Operation::computeResult`. This parameter is currently unused.
RobinTF
force-pushed
the
refactor-result-table
branch
from
51eaabf
to
93a5892
Compare
RobinTF
force-pushed
the
refactor-result-table
branch
from
c7ebab6
to
000af28
Compare
hannahbast
pushed a commit
that referenced
this pull request
Jun 13, 2024
This makes the code much simpler, and makes no difference for almost all queries. The expensive part (reading from disk and decompressing) is still done in parallel, only the writing to the `IdTable` is now serialized + there is an additional copy compared to before. An example query that is slower now because of this change is: materialize a large index scan (for example, for the predicate `rdf:type`) and group by subject (there is a shortcut for grouping by object when there are few objects). But such queries will become lazy soon anyway (see #1350) and then this will be irrelevant.
realHannes
pushed a commit
to realHannes/qlever
that referenced
this pull request
Jun 15, 2024
…eiburg#1323) This makes the code much simpler, and makes no difference for almost all queries. The expensive part (reading from disk and decompressing) is still done in parallel, only the writing to the `IdTable` is now serialized + there is an additional copy compared to before. An example query that is slower now because of this change is: materialize a large index scan (for example, for the predicate `rdf:type`) and group by subject (there is a shortcut for grouping by object when there are few objects). But such queries will become lazy soon anyway (see ad-freiburg#1350) and then this will be irrelevant.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still WIP. Currently missing: