Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CopyableMutex and CopyableAtomic #1398

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

joka921
Copy link
Member

@joka921 joka921 commented Jul 12, 2024

They behave like std::mutex and std:atomic but also have copy constructor and copy assignment. For CopyableAtomic the current value is copied, for CopyableMutex the copy constructor copies nothing and the copy assignment is a noop.

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.14%. Comparing base (14d6e1c) to head (992e670).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1398      +/-   ##
==========================================
+ Coverage   89.06%   89.14%   +0.08%     
==========================================
  Files         328      333       +5     
  Lines       29294    29500     +206     
  Branches     3262     3291      +29     
==========================================
+ Hits        26090    26298     +208     
+ Misses       2054     2051       -3     
- Partials     1150     1151       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@hannahbast hannahbast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1-1 with Johannes via the Atlantic, minor changes

Copy link
Member

@hannahbast hannahbast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor reformatting left

Copy link

sonarcloud bot commented Jul 15, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants