Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ORDER BY and FILTER on COUNT() columns #247 #248

Merged
merged 2 commits into from
May 15, 2019
Merged

Fix ORDER BY and FILTER on COUNT() columns #247 #248

merged 2 commits into from
May 15, 2019

Commits on May 13, 2019

  1. Add E2E query triggering the issue

    @niklas88
    niklas88 committed May 13, 2019
    Configuration menu
    Copy the full SHA
    2e41b4f View commit details
    Browse the repository at this point in the history

  2. Fix column mapping for resultSortedOn() 

    previously we were using the column mapping of the child subtree,
however that can be wrong for the result when new columns are added
(e.g. by using COUNT()). Somehow this was masked in previous versions of
the column mapping.
    @niklas88
    niklas88 committed May 13, 2019
    Configuration menu
    Copy the full SHA
    5737b66 View commit details
    Browse the repository at this point in the history