No -t flag, MAINTAINER in Dockerfile fixes #264
#265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
The changes in the Dockerfile work as expected and fix the problems described in #264.
.dockerignore
Outdated
| @@ -2,3 +2,4 @@ Dockerfile | |||
| index/* | |||
| e2e_data/* | |||
| build/* | |||
| output/* | |||
There was a problem hiding this comment.
This directory does not exist on a fresh clone
There was a problem hiding this comment.
It could be possible to ignore all but exempt the needed directories using something like (.dockerignore)
*
!e2e
!src
!test
!third_party
[...]
This could exclude all directories but obviously needs to be tested first as it's just a quick idea.
There was a problem hiding this comment.
Yes these directories are added by the evaluation and end to end test stuff. I think your latter idea is good. Will try that out now
lehmann-4178656ch
approved these changes
Jul 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing more nothing less