Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring the ParsedQuery class #323

Merged
merged 12 commits into from
Apr 24, 2020
Merged

Refactoring the ParsedQuery class #323

merged 12 commits into from
Apr 24, 2020

Commits on Apr 16, 2020

  1. Refactor the ParsedQuery class to use std::variant for the different … 

    …childGraphPattern types

- Todo : remove outcommented code
- Todo: reinstate the "toString" class.
    @joka921
    joka921 committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    2972a52 View commit details
    Browse the repository at this point in the history

  2. Finished the Todos. 

    Start simplifying the parsedQuery by removing the unnecessary shared_ptr and manual constructor shenanigans.
    @joka921
    joka921 committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    4266195 View commit details
    Browse the repository at this point in the history

  3. Defaulted/Deleted Copy/Move operations for GraphPattern.

    @joka921
    joka921 committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    34df850 View commit details
    Browse the repository at this point in the history

  4. Removed one Level of std::shared_ptr where there is no shared ownership

    @joka921
    joka921 committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    de0b046 View commit details
    Browse the repository at this point in the history

  5. Broke the cyclic redundancy of GraphPattern and GraphPatternOperation

    @joka921
    joka921 committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    3fd86e3 View commit details
    Browse the repository at this point in the history

  6. Removed one more Level of shared_ptrs where they were not needed.

    @joka921
    joka921 committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    f690c16 View commit details
    Browse the repository at this point in the history

  7. Also no more shared_ptr for the transPath

    @joka921
    joka921 committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    a20d333 View commit details
    Browse the repository at this point in the history

  8. Subqueries now also own their ParsedQueries.

    @joka921
    joka921 committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    29afb80 View commit details
    Browse the repository at this point in the history

  9. This has a strange bug, TODO find and fix it.

    @joka921
    joka921 committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    9cbe8b4 View commit details
    Browse the repository at this point in the history

  10. Bump the branch

    @joka921
    joka921 committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    552eb6d View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2020

  1. submodules corrected

    @joka921
    joka921 committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    e48b0cf View commit details
    Browse the repository at this point in the history

  2. Added additional check for the queryPlannerTest.

    @joka921
    joka921 committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    40d9b12 View commit details
    Browse the repository at this point in the history