-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
F.memory limited cache #348
Merged
Merged
Commits on Apr 10, 2021
-
- There is now also a configurable limit on the actual size of cache elements, including a limit on the maximal size of a single cache element - Pinned elements also count towards the size. - Results are only inserted into the cache once they are fully computed. - If a result is requested from the cache, while it is still being computed, this computation can be awaited. This functionality existed before, but is now encapsulated in a separate CacheAdapter class. This encapsulation allows us to test this functionality which was previously untested. - Removed thread-safety from the cache class itself, As it can be added easily using ad_utility::Synchronized
Configuration menu - View commit details
-
Copy full SHA for 86a516c - Browse repository at this point
Copy the full SHA 86a516cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e62aab - Browse repository at this point
Copy the full SHA 3e62aabView commit details
Commits on Apr 11, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 5f26897 - Browse repository at this point
Copy the full SHA 5f26897View commit details -
Added tests for pinned CacheAdapter functionality, added remarks by H…
…annah on these tests, and make them pass deterministically.
Configuration menu - View commit details
-
Copy full SHA for 099e3bb - Browse repository at this point
Copy the full SHA 099e3bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e3dfbf - Browse repository at this point
Copy the full SHA 6e3dfbfView commit details -
Still missing: Cache size which is settable from the commandline.
Configuration menu - View commit details
-
Copy full SHA for 20ed72a - Browse repository at this point
Copy the full SHA 20ed72aView commit details -
Finished including Hannah's review:
Added commandline support for the cache configuration and renamed several constants.
Configuration menu - View commit details
-
Copy full SHA for 0699d6f - Browse repository at this point
Copy the full SHA 0699d6fView commit details
Commits on Apr 12, 2021
-
Configuration menu - View commit details
-
Copy full SHA for c5c3bec - Browse repository at this point
Copy the full SHA c5c3becView commit details -
Configuration menu - View commit details
-
Copy full SHA for b5cd717 - Browse repository at this point
Copy the full SHA b5cd717View commit details
Commits on Apr 16, 2021
-
Configuration menu - View commit details
-
Copy full SHA for d74095a - Browse repository at this point
Copy the full SHA d74095aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 460f0e5 - Browse repository at this point
Copy the full SHA 460f0e5View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.