Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F.memory limited cache #348

Merged
merged 11 commits into from
Apr 16, 2021
Merged

Commits on Apr 10, 2021

  1. Memory Limit for the Cache

    - There is now also a configurable limit on the actual size
      of cache elements, including a limit on the maximal size
      of a single cache element
    - Pinned elements also count towards the size.
    - Results are only inserted into the cache once they are fully
      computed.
    - If a result is requested from the cache, while it is still
      being computed, this computation can be awaited. This
      functionality existed before, but is now encapsulated
      in a separate CacheAdapter class. This encapsulation allows
      us to test this functionality which was previously untested.
    - Removed thread-safety from the cache class itself,
      As it can be added easily using ad_utility::Synchronized
    joka921 committed Apr 10, 2021
    Configuration menu
    Copy the full SHA
    86a516c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3e62aab View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2021

  1. Configuration menu
    Copy the full SHA
    5f26897 View commit details
    Browse the repository at this point in the history
  2. Added tests for pinned CacheAdapter functionality, added remarks by H…

    …annah on these tests, and make them pass deterministically.
    joka921 committed Apr 11, 2021
    Configuration menu
    Copy the full SHA
    099e3bb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6e3dfbf View commit details
    Browse the repository at this point in the history
  4. Changes from Hannah's review.

    Still missing: Cache size which is settable from the commandline.
    joka921 committed Apr 11, 2021
    Configuration menu
    Copy the full SHA
    20ed72a View commit details
    Browse the repository at this point in the history
  5. Finished including Hannah's review:

    Added commandline support for the cache configuration and renamed several constants.
    joka921 committed Apr 11, 2021
    Configuration menu
    Copy the full SHA
    0699d6f View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2021

  1. Configuration menu
    Copy the full SHA
    c5c3bec View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b5cd717 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2021

  1. Configuration menu
    Copy the full SHA
    d74095a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    460f0e5 View commit details
    Browse the repository at this point in the history