Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak in SortPerformanceEstimator (faster + log) #398

Merged
merged 3 commits into from
Jun 2, 2021
Merged

Tweak in SortPerformanceEstimator (faster + log) #398

merged 3 commits into from
Jun 2, 2021

Commits on May 8, 2021

  1. Tweak in SortPerformanceEstimator (faster + log) 

    1. Right now, the estimation takes several minutes. Is that really
necessary? The main culprits are the 100,000,000 tests, so I removed
them. OK?

2. The log had two lines per sort ("Sorting ..." and "done"), it's now
only one line.

TODO: It is confusing that the sort estimation is the very first thing one
sees in the server log upon startup. The server initialization comes
afterwards. Is realize that there are reasons for this in the code.
Nevertheless, is it possible to do this the other way round?
    @hannahbast
    hannahbast committed May 8, 2021
    Configuration menu
    Copy the full SHA
    3271943 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2021

  1. Two-phase initialization for the sortPerformanceEstimator. 

    This allows us, to limit the maximum sample size depending on the Knowledgebase size.
    @joka921
    joka921 committed May 28, 2021
    Configuration menu
    Copy the full SHA
    2ab492e View commit details
    Browse the repository at this point in the history

Commits on May 29, 2021

  1. Two last changes from Hannah's review.

    @joka921
    joka921 committed May 29, 2021
    Configuration menu
    Copy the full SHA
    11f4bf0 View commit details
    Browse the repository at this point in the history