Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce own logic in StringUtils.h #557

Merged
merged 8 commits into from
Jan 27, 2022
Merged

Reduce own logic in StringUtils.h #557

merged 8 commits into from
Jan 27, 2022

Conversation

RobinTF
Copy link
Collaborator

@RobinTF RobinTF commented Jan 27, 2022

Follow up to #553 as discussed with @joka921

joka921
joka921 approved these changes Jan 27, 2022
View reviewed changes
Copy link
Member

@joka921 joka921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for improving our codebase.
I only have few very small wishes.

src/engine/QueryPlanningCostFactors.cpp Outdated Show resolved Hide resolved
src/parser/SparqlParser.cpp Outdated Show resolved Hide resolved
src/util/Conversions.h Outdated Show resolved Hide resolved
joka921
joka921 approved these changes Jan 27, 2022
View reviewed changes
Copy link
Member

@joka921 joka921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny remark for a function that is probably never used, but it's good to find out, what from_chars actually returns.

src/engine/QueryPlanningCostFactors.cpp Outdated Show resolved Hide resolved
joka921
joka921 approved these changes Jan 27, 2022
View reviewed changes
Copy link
Member

@joka921 joka921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This will be merged when the Checks are finished.

@joka921 joka921 merged commit c79d73c into ad-freiburg:master Jan 27, 2022
@RobinTF RobinTF deleted the move-strip branch January 28, 2022 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joka921 joka921 joka921 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RobinTF @joka921