Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about secrets #24

Closed
wants to merge 1 commit into from
Closed

Add note about secrets #24

wants to merge 1 commit into from

Conversation

tenhobi
Copy link
Contributor

@tenhobi tenhobi commented Oct 29, 2019

Add a note about using and creating secrets.

Fixes #23

@tenhobi tenhobi requested a review from koppor October 29, 2019 15:17
@ad-m
Copy link
Owner

ad-m commented Oct 29, 2019

I would add a sentence about the fact that when accessing the repository from which the GitHub Actions event is triggered, it creates a token for us without any additional configuration. This solves most cases of using the our action and saves reading long documentation.

@simon300000
Copy link

Note: If we want the push to trigger the actions again or something else, you will need to create you own token, since the GitHub's token does not have permission to do anything else other than push.

Copy link
Contributor

@koppor koppor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That what @ad-m says. I would also replace "docs" by "GitHub help" to make it clear that the docs is not by this action, but a general one.

@ZPascal
Copy link
Collaborator

ZPascal commented Mar 16, 2024

I'm closing the PR because I think the use of tokens, permissions, and secrets is in general already documented here and in the GitHub upstream documentation. Feel free to reopen it if needed.

@ZPascal ZPascal closed this Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to set GITHUB_TOKEN?
5 participants