Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

03_branching Conditional Syntax diagram is not Python #146

Closed
anselrognlie opened this issue Aug 6, 2020 · 1 comment
Closed

03_branching Conditional Syntax diagram is not Python #146

anselrognlie opened this issue Aug 6, 2020 · 1 comment

Comments

@anselrognlie
Copy link
Contributor

The diagram shown under conditional syntax does not look like Python

  • no : after the expression
  • end keyword denoting the end of a block

A diagram reflecting Python syntax should be used. If it is difficult to show where a block ends, consider following the conditional block with a simple print, such as

if 1 < 2:
    print("inside the block")

print("outside the block")

The various parts of the conditional and block could then be labelled easily per the current diagram.

Alternatively, consider removing the diagram entirely, as there are many other examples in the lesson as it is.

@anselrognlie
Copy link
Contributor Author

migrated to notebook comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant