Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add can_parse to benchmarks #653

Merged
merged 3 commits into from
May 12, 2024

Conversation

CarlosEduR
Copy link
Collaborator

Relates to: #377

Load Average: 0.06, 0.09, 0.09
ada spec: Ada follows whatwg/url
bad urls: ---------------------
ada---count of bad URLs       26
servo/url---count of bad URLs 26
whatwg---count of bad URLs    26
-------------------------------

bytes/URL: 86.859205
curl : OMITTED
input bytes: 8688092
number of URLs: 100025
performance counters: Enabled
rust version : 1.76.0
zuri : OMITTED
--------------------------------------------------------------------------------------------
Benchmark                                  Time             CPU   Iterations UserCounters...
--------------------------------------------------------------------------------------------
BasicBench_AdaURL_href              30362199 ns     30356773 ns           23 GHz=4.29081 cycle/byte=14.8176 cycles/url=1.28704k instructions/byte=34.4159 instructions/cycle=2.32264 instructions/ns=9.96599 instructions/url=2.98933k ns/url=299.954 speed=286.199M/s time/byte=3.49407ns time/url=303.492ns url/s=3.29498M/s
BasicBench_AdaURL_aggregator_href   19152527 ns     19150861 ns           36 GHz=4.26512 cycle/byte=9.37811 cycles/url=814.575 instructions/byte=23.009 instructions/cycle=2.45349 instructions/ns=10.4644 instructions/url=1.99855k ns/url=190.985 speed=453.666M/s time/byte=2.20427ns time/url=191.461ns url/s=5.223M/s
BasicBench_AdaURL_CanParse          19546808 ns     19545551 ns           36 GHz=4.29825 cycle/byte=9.54439 cycles/url=829.018 instructions/byte=23.5847 instructions/cycle=2.47105 instructions/ns=10.6212 instructions/url=2.04855k ns/url=192.874 speed=444.505M/s time/byte=2.24969ns time/url=195.407ns url/s=5.11753M/s
BasicBench_whatwg                   52564561 ns     52559116 ns           13 GHz=4.26788 cycle/byte=25.6363 cycles/url=2.22675k instructions/byte=68.8033 instructions/cycle=2.68382 instructions/ns=11.4542 instructions/url=5.9762k ns/url=521.746 speed=165.301M/s time/byte=6.04956ns time/url=525.46ns url/s=1.9031M/s
BasicBench_ServoUrl                 81868634 ns     81861762 ns            8 GHz=4.28335 cycle/byte=40.2365 cycles/url=3.49491k instructions/byte=108.216 instructions/cycle=2.6895 instructions/ns=11.5201 instructions/url=9.39957k ns/url=815.93 speed=106.131M/s time/byte=9.42229ns time/url=818.413ns url/s=1.22188M/s

@CarlosEduR CarlosEduR changed the title Add can_parse to benchmarks feat: Add can_parse to benchmarks May 12, 2024
@CarlosEduR CarlosEduR changed the title feat: Add can_parse to benchmarks Add can_parse to benchmarks May 12, 2024
benchmarks/benchmark_template.cpp Outdated Show resolved Hide resolved
@anonrig anonrig requested a review from lemire May 12, 2024 23:02
@lemire lemire marked this pull request as ready for review May 12, 2024 23:36
@lemire
Copy link
Member

lemire commented May 12, 2024

Marked as ready for review. Except for the issue caught by @anonrig, I would merge this as-is. Then we should start discussions as to how to make things faster.

@anonrig anonrig merged commit e9dcc89 into ada-url:main May 12, 2024
22 checks passed
@CarlosEduR
Copy link
Collaborator Author

Nice, thanks @anonrig and @lemire.

@lemire
Copy link
Member

lemire commented May 13, 2024

We need a strategy next to allow optimization... without writing a massive amount of code. We need to think this through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants