build: don't force a specific compiler/version #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ju1ius
changed the title
|
Running tests. |
anonrig
reviewed
Jan 31, 2024
| @@ -175,8 +173,6 @@ fn main() { | |||
| println!("cargo:rustc-link-lib=c"); | |||
| build.file("./deps/wasi_to_unknown.cpp"); | |||
| } | |||
| } else if !(compile_target_os == "windows" && compile_target_env == "msvc") { | |||
There was a problem hiding this comment.
Is it possible to add a GitHub workflow to ensure your case never gets broken?
There was a problem hiding this comment.
You mean adding an ubuntu+gcc variant to the matrix?
There was a problem hiding this comment.
You mean adding an ubuntu+gcc variant to the matrix?
I could do that (i.e. by passing CXX=g++ in the env), but I don't see an easy way to test that the build actually ends up using gcc...
anonrig
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #59 for context.
Closes #59.