Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't require/use Bundler at runtime #3

Closed
wants to merge 1 commit into from
Closed

Don't require/use Bundler at runtime #3

wants to merge 1 commit into from

Conversation

cgriego
Copy link

@cgriego cgriego commented Oct 15, 2010

Our application already uses Bundler and relies on the gemspec to control dependencies.

@cgriego
Copy link
Author

cgriego commented Nov 4, 2010

Bundler is designed for use for managing an application's dependencies while gemspecs manage gem dependencies. You can see how the built-in Bundler rubygem generators setup using Bundler for development of a rubygem but not using it at runtime. http://gembundler.com/rubygems.html

@cgriego
Copy link
Author

cgriego commented Nov 22, 2010

Here's an article written almost 2 years ago about not requiring rubygems in library code. https://gist.github.com/54177

There's also work in Bundler to support an application itself to not need to use Bundler at runtime for compatibility reasons. rubygems/bundler@9278bf5

@cgriego
Copy link
Author

cgriego commented Mar 1, 2011

I'm still hoping to see this change made in this gem. Without it, I'm unable to use the gem directly.

Here is additional information on using Bundler for application vs gem development.
http://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/

@adacosta
Copy link
Owner

Hi C,

Sorry for the delay. I attempted an updated. Can you let me know if if looks good?

Thanks,

Alan

@adacosta adacosta closed this Jun 22, 2011
@floehopper floehopper mentioned this pull request Mar 7, 2017
Closed
floehopper added a commit to freerange/mongoid_rails_migrations that referenced this pull request Mar 7, 2017
@floehopper
Avoid calling Bundler.require in library code
50b9137 
This was causing us problems [1] in an application which uses Bundler
when we upgraded to Bundler >= v1.13.0.

I think the right solution is something along the lines of adacosta#3, but I'm
trying this as a temporary quick fix.

[1]: alphagov/manuals-publisher#816
floehopper added a commit to alphagov/manuals-publisher that referenced this pull request Mar 7, 2017
@floehopper
Use fork of mongoid_rails_migrations to fix build
ffeee9c 
* This is an attempt to fix the problem described in #816. It uses a
forked version of mongoid_rails_migrations. The branch in that fork
was branched off the v1.0.0 tag, which is the version of the gem that
was specified in our `Gemfile`. This is so that we keep the changes to
our app to a minimum.

* This fix is a bit of a bodge - the proper fix would be along the
lines of adacosta/mongoid_rails_migrations#3, but given that the failing
build is a significant blocker, it feels as if this is worth a try.
If it works OK, we can work on getting the proper fix in place.

* I installed v1.14.5 of Bundler which is the version now specified in
govuk-puppet [1] for Ruby v2.2.4. Hence the change to `BUNDLED WITH`
in the `Gemfile`.

* I've run a migration locally to ensure that the gem still works OK
even with this patch in place.

[1]: https://github.com/alphagov/govuk-puppet/blob/e2d61705aaf6da180a781b6f46f83235fd890df0/modules/govuk_rbenv/manifests/all.pp#L46
@floehopper floehopper mentioned this pull request Mar 7, 2017
Merged
floehopper added a commit to alphagov/mongoid_rails_migrations that referenced this pull request Mar 7, 2017
@floehopper
Avoid calling Bundler.require in library code
4db2344 
This was causing us problems [1] in an application which uses Bundler
when we upgraded to Bundler >= v1.13.0.

I think the right solution is something along the lines of adacosta#3, but I'm
trying this as a temporary quick fix.

Note that this branch is based off the v1.0.0 tag which is the version
of the gem that we are currently using in our app.

[1]: alphagov/manuals-publisher#816
floehopper added a commit to alphagov/manuals-publisher that referenced this pull request Mar 7, 2017
@floehopper
Use fork of mongoid_rails_migrations to fix build
a80f96c 
* This is an attempt to fix the problem described in #816. It uses a
forked version of mongoid_rails_migrations. The branch in that fork
was branched off the v1.0.0 tag, which is the version of the gem that
was specified in our `Gemfile`. This is so that we keep the changes to
our app to a minimum.

* This fix is a bit of a bodge - the proper fix would be along the
lines of adacosta/mongoid_rails_migrations#3, but given that the failing
build is a significant blocker, it feels as if this is worth a try.
If it works OK, we can work on getting the proper fix in place.

* I installed v1.14.5 of Bundler which is the version now specified in
govuk-puppet [1] for Ruby v2.2.4. Hence the change to `BUNDLED WITH`
in the `Gemfile`.

* I've run a migration locally to ensure that the gem still works OK
even with this patch in place.

[1]: https://github.com/alphagov/govuk-puppet/blob/e2d61705aaf6da180a781b6f46f83235fd890df0/modules/govuk_rbenv/manifests/all.pp#L46
@chrisroos chrisroos mentioned this pull request Mar 15, 2017
Open
@floehopper floehopper mentioned this pull request May 24, 2017
Merged
floehopper added a commit to alphagov/mongoid_rails_migrations that referenced this pull request May 25, 2017
@floehopper
Avoid calling Bundler.require in library code
4affab7 
This was causing us problems [1] in an application which uses Bundler
when we upgraded to Bundler >= v1.13.0.

I think the right solution is something along the lines of adacosta#3, but I'm
trying this as a temporary quick fix.

Note that this branch is based off the v1.0.0 tag which is the version
of the gem that we are currently using in our app.

[1]: alphagov/manuals-publisher#816
floehopper added a commit to alphagov/mongoid_rails_migrations that referenced this pull request May 25, 2017
@floehopper
Avoid calling Bundler.require in library code
e3e0374 
This was causing us problems [1] in an application which uses Bundler
when we upgraded to Bundler >= v1.13.0.

I think the right solution is something along the lines of these pull
requests [2,3], but since these haven't been merged by the maintainer,
I'm using this commit as a temporary fix.

[1]: alphagov/manuals-publisher#816
[2]: adacosta#3
[3]: adacosta#40
floehopper added a commit to alphagov/mongoid_rails_migrations that referenced this pull request May 25, 2017
@floehopper
Avoid calling Bundler.require in library code
7dc2c19 
This was causing us problems [1] in an application which uses Bundler
when we upgraded to Bundler >= v1.13.0.

I think the right solution is something along the lines of these pull
requests [2,3], but since these haven't been merged by the maintainer,
I'm using this commit as a temporary fix.

[1]: alphagov/manuals-publisher#816
[2]: adacosta#3
[3]: adacosta#40
floehopper added a commit to alphagov/manuals-publisher that referenced this pull request May 25, 2017
@floehopper
Upgrade mongoid_rails_migrations gem to v1.1.0+
598f669 
This upgrade from v1.0.0 includes a few changes to improve compatibility
with more recent versions of Mongoid and Rails. However, I haven't been
able to use the v1.1.0 release version of the gem for three reasons:

* Since we're now on Mongoid v6, we need the fix [1] in the latest
commit on master in the canonical repo in order for
`Mongoid::Migration.connection` method to work. I've incorporated this
commit in the new branch in the alphagov fork.

* Since we're now on Rails v5, we need a fix [2] for the absence of
`alias_method_chain`. I've incorporated the commit from this PR [3] into
the new branch in the alphagov fork.

* The problem described in #816 still exists. The maintainer of the gem
still hasn't fixed the problem. This earlier suggested fix [4] has been
closed without explanation. A new fix [5] has been proposed and I've
added a comment to explain why I think it should be merged. Therefore
I've incorporated my original fix as the last commit in the new branch
in the alphagov fork.

I've checked that I can generate and run the following migration:

    class Foo < Mongoid::Migration
      def self.up
        p SectionEdition.count
        p SectionEdition.collection
        p connection.database.collection_names
      end

      def self.down
      end
    end

I've also updated the existing migration so that I think they would
work. However, I haven't tested them.

[1]: adacosta/mongoid_rails_migrations@0074dbf
[2]: stormz/mongoid_rails_migrations@b9158cd
[3]: adacosta/mongoid_rails_migrations#44
[4]: adacosta/mongoid_rails_migrations#3
[5]: adacosta/mongoid_rails_migrations#40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cgriego @adacosta