a couple of pet peves

[ghost]

Drawing bitmaps may be a bit faster due to pre-calculation of values and not repeatingly reading the same byte from memory (...by a relatively expensive pgm_read_byte call; using a temporary uint8_t for that is probably slightly faster).

Please note that I have not tested it yet.

[tdicola]

Interesting, is it at least functionally equivalent to the current code? i.e. it still renders examples bitmaps the same as before.

[fingolfin]

This PR does a lot of code formatting. Huge parts of it do nothing but change formatting, or replacing if/else by the ternary ? : operator. That makes it rather difficult to find the actual behavior changes in it, i.e. makes reviewing the code changes harder :-(.

It also does at least on thing not described in description of the pull request: It changes drawXBitmap to simply call drawBitmap.

Anyway, as far as I can tell, the main issue (avoiding re-reading of the same byte 8 times, to get each bit) was fixed in commits 9cb1ec4 and a6a9359 so this PR might be obsolete...?

[ghost]

Yes, could be.
I'm sorry I did not verify my changes: I couldn't get the display work
anymore.

On Mon, Jan 4, 2016 at 12:20 AM, Max Horn notifications@github.com wrote:

This PR does a lot of code formatting. Huge parts of it do nothing but
change formatting, or replacing if/else by the ternary ? : operator. That
makes it rather difficult to find the actual behavior changes in it, i.e.
makes reviewing the code changes harder :-(.

It also does at least on thing not described in description of the pull
request: It changes drawXBitmap to simply call drawBitmap.

Anyway, as far as I can tell, the main issue (avoiding re-reading of the
same byte 8 times, to get each bit) was fixed in commits 9cb1ec4
9cb1ec4
and a6a9359
a6a9359
so this PR might be obsolete...?

—
Reply to this email directly or view it on GitHub
#57 (comment)
.

www.vanheusden.com www.slimwinnen.nl | www.smartwinning.info