Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ultimate GPS #30

Merged
merged 4 commits into from
Aug 16, 2014
Merged

Ultimate GPS #30

merged 4 commits into from
Aug 16, 2014

Conversation

flybob
Copy link

@flybob flybob commented Aug 11, 2014

Changed header and shield sd_log to add 10 sec logging capacity. More efficient for large log files.

@tdicola
Copy link
Contributor

tdicola commented Aug 16, 2014

Thanks for sending the pull with the new logging frequency command, will merge now.

tdicola added a commit that referenced this pull request Aug 16, 2014
@tdicola tdicola merged commit f72d2ac into adafruit:master Aug 16, 2014
@tdicola
Copy link
Contributor

tdicola commented Aug 16, 2014

Oh actually I noticed the variable is called 100mhz when it really should be 10hz (10 times a second instead of 100 million times a second). Made a small change to make the name consistent: b1f0c6e

@flybob
Copy link
Author

flybob commented Aug 16, 2014

It is 100 milihertz ( small m) so the write rate is every 10 seconds.

Bob
On 8/15/2014 9:41 PM, Tony DiCola wrote:

Oh actually I noticed the variable is called 100mhz when it really
should be 10hz (10 times a second instead of 100 million times a
second). Made a small change to make the name consistent: b1f0c6e
b1f0c6e


Reply to this email directly or view it on GitHub
#30 (comment).

@tdicola
Copy link
Contributor

tdicola commented Aug 16, 2014

Ohh right, thanks for clarifying. Let's stick with hertz so it's the same as other command units. Thanks again for submitting the change!

@flybob
Copy link
Author

flybob commented Aug 17, 2014

No prob. Then it is 0.1 Hz Are you going to change or do you want me
to resubmit pull?

Bob

On 8/16/2014 2:42 PM, Tony DiCola wrote:

Ohh right, thanks for clarifying. Let's stick with hertz so it's the
same as other command units. Thanks again for submitting the change!


Reply to this email directly or view it on GitHub
#30 (comment).

@tdicola
Copy link
Contributor

tdicola commented Aug 18, 2014

Ack, great point. I should have a cup of coffee before I look at unit conversions. :) Hrm since the dot can't be used I think your millihertz suggestion makes more sense. I'll spell it out though so it doesn't trip anyone up that might think it's 100 megahertz.

@flybob
Copy link
Author

flybob commented Aug 18, 2014

That's why I used mHz as the "dot" did not work.

No prob. The slower rate seems to improve reliability and not fill up
the SD card as fast. Unless you are a missile traveling extremely
fast, I don't know why more than 6 updated position saves per minute are
required.

Bob
On 8/18/2014 2:08 PM, Tony DiCola wrote:

Ack, great point. I should have a cup of coffee before I look at unit
conversions. :) Hrm since the dot can't be used I think your
millihertz suggestion makes more sense. I'll spell it out though so it
doesn't trip anyone up that might think it's 100 megahertz.


Reply to this email directly or view it on GitHub
#30 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants