Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getTINT() return #28

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Fix getTINT() return #28

merged 1 commit into from
Jul 27, 2023

Conversation

caternuson
Copy link
Contributor

For #27.

Just changes local variable types to long to match return.

Fixes issue on UNO. Some output from example sketch in issue thread:

Current ATIME for sensor : 200
Current ASTEP for sensor : 600
Current GAIN for sensor : 1
Current TINT (ms) for sensor : 335
TINT calculated 335
Reading ADC4/Clear    : 45
Basic counts ADC4/Clear    : 0.13
Basic counts semi manual for sensor : 0.00
Basic counts manual for sensor : 0.00
Current ATIME for sensor : 225
Current ASTEP for sensor : 600
Current GAIN for sensor : 1
Current TINT (ms) for sensor : 377
TINT calculated 377
Reading ADC4/Clear    : 51
Basic counts ADC4/Clear    : 0.14
Basic counts semi manual for sensor : 0.00
Basic counts manual for sensor : 0.00
Current ATIME for sensor : 250
Current ASTEP for sensor : 600
Current GAIN for sensor : 1
Current TINT (ms) for sensor : 419
TINT calculated 419
Reading ADC4/Clear    : 57
Basic counts ADC4/Clear    : 0.14
Basic counts semi manual for sensor : 0.00
Basic counts manual for sensor : 0.00

Focusing on lines that matter, for example, these two lines agree now:

Current TINT (ms) for sensor : 419
TINT calculated 419

@caternuson
Copy link
Contributor Author

@ladyada for review

@ladyada
Copy link
Member

ladyada commented Jul 27, 2023

good find!

@caternuson caternuson merged commit 868673f into adafruit:master Jul 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants