Update digitalio docstrings to be more in line with CircuitPython #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FoamyGuy
reviewed
Sep 10, 2021
| @@ -129,7 +129,7 @@ def write_readinto( | |||
| self._spi.bits_per_word = self.bits | |||
| data = self._spi.transfer(list(buffer_out[out_start : out_end + 1])) | |||
| for i in range((in_end - in_start)): | |||
| buffer_in[i + in_start] = data[i] | |||
| buffer_in[i + in_start] = data[i + 1] | |||
There was a problem hiding this comment.
The docs changes look good to me.
Is this + 1 intentional? If so this PR LGTM.
There was a problem hiding this comment.
Sort of. That wasn't supposed to be part of this PR. It was for another issue that I started to test a while ago and forgot to revert. I'll remove that for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #499.