Add Support for Orangepi 4 #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makermelissa
approved these changes
Sep 12, 2022
|
Hi @twa127, thanks for your contribution. I'am also using Orange Pi 4 and have a question about your PR. I see some mismatch when compare to board pinout and the output of
|
|
Hi,You are correct, do you want to write a pin mapping or do you want me to do it?Regards TerrySent from my iPhoneOn 7 Feb 2023, at 23:11, Andrey Yastrebov ***@***.***> wrote:
Hi @twa127, thanks for your contribution.
I'am also using Orange Pi 4 and have a question about your PR.
Are you sure that the pins mapping in orangepi4.py is done correct?
I see some mismatch when compare to board pinout and the output of gpio readall
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Ok, I'll make pin mapping myself and open pull request, thanks! |
|
ThanksSent from my iPhoneOn 9 Feb 2023, at 11:54, Andrey Yastrebov ***@***.***> wrote:
Ok, I'll make pin mapping myself and open pull request, thanks!
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.