Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display a message if user tries to set freq on linux #708

Merged
merged 4 commits into from
Sep 14, 2023
Merged

Display a message if user tries to set freq on linux #708

merged 4 commits into from
Sep 14, 2023

Conversation

makermelissa
Copy link
Contributor

Fixes #682. Also improves issue template messages.

@makermelissa makermelissa requested a review from a team September 12, 2023 20:09
tannewt
tannewt requested changes Sep 13, 2023
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion instead of print.

src/adafruit_blinka/microcontroller/generic_linux/i2c.py Outdated Show resolved Hide resolved
tannewt
tannewt approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update!

@tannewt tannewt merged commit 2d884df into adafruit:main Sep 14, 2023
1 check passed
@makermelissa makermelissa mentioned this pull request Sep 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why can't I2C baudrate/frequency be set in Python?
2 participants
@makermelissa @tannewt