Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ODROID_M1 board detection #771

Merged

Conversation

mahenzon
Copy link
Contributor

@mahenzon mahenzon commented Jan 6, 2024

Yep, it worked because

"abc" in "abc"  # is True

But I guess the idea was to check if it's one of the boards (and for now the tuple of boards has only one member)

Same as:

elif board_id in ("RASPBERRY_PI_5",):

Copy link
Contributor

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, makes sense.

@makermelissa makermelissa merged commit 28aee6f into adafruit:main Jan 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants