Skip to content

Commit

Permalink
Merge pull request #125 from janvolck/main
Browse files Browse the repository at this point in the history
make chip_select pin optional in SPI fourwire
  • Loading branch information
makermelissa committed Jan 3, 2024
2 parents 57ea21d + 1566aef commit 448a5d5
Showing 1 changed file with 24 additions and 7 deletions.
31 changes: 24 additions & 7 deletions displayio/_fourwire.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def __init__(
spi_bus: busio.SPI,
*,
command: microcontroller.Pin,
chip_select: microcontroller.Pin,
chip_select: Optional[microcontroller.Pin] = None,
reset: Optional[microcontroller.Pin] = None,
baudrate: int = 24000000,
polarity: int = 0,
Expand All @@ -61,8 +61,13 @@ def __init__(
"""
self._dc = digitalio.DigitalInOut(command)
self._dc.switch_to_output(value=False)
self._chip_select = digitalio.DigitalInOut(chip_select)
self._chip_select.switch_to_output(value=True)

if chip_select is not None:
self._chip_select = digitalio.DigitalInOut(chip_select)
self._chip_select.switch_to_output(value=True)
else:
self._chip_select = None

self._frequency = baudrate
self._polarity = polarity
self._phase = phase
Expand All @@ -78,7 +83,10 @@ def _release(self):
self.reset()
self._spi.deinit()
self._dc.deinit()
self._chip_select.deinit()

if self._chip_select is not None:
self._chip_select.deinit()

if self._reset is not None:
self._reset.deinit()

Expand Down Expand Up @@ -123,7 +131,11 @@ def _send(
data: ReadableBuffer,
):
self._dc.value = data_type == DISPLAY_DATA
if chip_select == CHIP_SELECT_TOGGLE_EVERY_BYTE:

if (
self._chip_select is not None
and chip_select == CHIP_SELECT_TOGGLE_EVERY_BYTE
):
for byte in data:
self._spi.write(bytes([byte]))
self._chip_select.value = True
Expand All @@ -146,10 +158,15 @@ def _begin_transaction(self) -> bool:
self._spi.configure(
baudrate=self._frequency, polarity=self._polarity, phase=self._phase
)
self._chip_select.value = False

if self._chip_select is not None:
self._chip_select.value = False

return True

def _end_transaction(self) -> None:
"""End the SPI transaction by unlocking and setting Chip Select"""
self._chip_select.value = True
if self._chip_select is not None:
self._chip_select.value = True

self._spi.unlock()

0 comments on commit 448a5d5

Please sign in to comment.