Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vectorio support #122

Merged
merged 6 commits into from
Jan 1, 2024
Merged

Add vectorio support #122

merged 6 commits into from
Jan 1, 2024

Conversation

makermelissa
Copy link
Contributor

Fixes #117.

@makermelissa makermelissa requested a review from a team December 29, 2023 20:18
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add vectorio here in pyproject.toml?

packages = ["displayio"]

The first time I tried testing this I got an error on the vectorio import internally in Blinka_DisplayIO. I added this and it seemed to resolve it. But then I tried to go back with it the original way to recreate the exact stacktrace and now I'm not having the same outcome any more. Perhaps I did something wrong when I installed it initially.

It might be good to keep pyprojet.toml and setup.py in sync even if it isn't required for all contexts as well though.

@FoamyGuy
Copy link
Contributor

The functionality and code look good to me. I tested it successfully with vectorio example code from the docs and PyGameDisplay library.

@makermelissa
Copy link
Contributor Author

Do we need to add vectorio here in pyproject.toml?

Yes, I believe so.

Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the addition!

@makermelissa makermelissa merged commit 3640a5c into adafruit:main Jan 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Vectorio Support
2 participants