-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vectorio support #122
Add vectorio support #122
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to add vectorio
here in pyproject.toml?
Adafruit_Blinka_Displayio/pyproject.toml
Line 45 in 0c50ba2
packages = ["displayio"] |
The first time I tried testing this I got an error on the vectorio import internally in Blinka_DisplayIO. I added this and it seemed to resolve it. But then I tried to go back with it the original way to recreate the exact stacktrace and now I'm not having the same outcome any more. Perhaps I did something wrong when I installed it initially.
It might be good to keep pyprojet.toml and setup.py in sync even if it isn't required for all contexts as well though.
The functionality and code look good to me. I tested it successfully with vectorio example code from the docs and PyGameDisplay library. |
Yes, I believe so. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for the addition!
Fixes #117.