Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to CircuitPython 9.0.0 API #131

Merged
merged 10 commits into from
Mar 20, 2024

Conversation

makermelissa
Copy link
Contributor

@makermelissa makermelissa commented Mar 19, 2024

Fixes #120. Tested successfully with an ST7789 TFT, SSD1680 eInk, and SSD1306 mono display via I2C. Also adds release drafter.

@makermelissa makermelissa requested a review from a team March 19, 2024 21:44
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just as background:

Right now CircuitPython 9.0.0 supports old and new namings, though with warnings.

We have not yet converted over libraries in an incompatible way, and we are still building 8.x bundles. When we stop building 8.x bundles, we will put a "last available 8.x bundle" link here: https://learn.adafruit.com/welcome-to-circuitpython/frequently-asked-questions#faq-3105289. We will wait a bit (a few weeks, I think) before stopping the bundles.

In the display libraries, most of the naming differences are only in the examples. Right now they are written to be both 8.x and 9.x compatible. When we stop building the 8.x bundles, we can remove the compatibility code.

Would you want to wait until then before merging this? I'm not sure who uses this and cares. Anyone who updates this library is going to have to change their code over, but maybe that's fine. If they're not ready they'll just use the previous major version.

@makermelissa
Copy link
Contributor Author

I think it's fine to merge. My plan was to release as 2.0.0 because of the different API.

@dhalbert dhalbert requested a review from tannewt March 19, 2024 22:26
@dhalbert
Copy link
Contributor

@tannewt just asking you to check the naming, since you know it well

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me! Thanks for the update!

@makermelissa makermelissa merged commit 6776bc6 into adafruit:main Mar 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update any changed APIs now that CircuitPython 9.0.0 has been released
3 participants