Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed links #7

Merged
merged 1 commit into from
May 24, 2021
Merged

Fixed links #7

merged 1 commit into from
May 24, 2021

Conversation

evaherrada
Copy link
Contributor

Just confirming this library should be called Adafruit_Board_Toolkit and not Adafruit_CircuitPython_Board_Toolkit, right?

@evaherrada
Copy link
Contributor Author

Also just tested building the docs locally and all the previously broken links work now

@evaherrada evaherrada linked an issue May 24, 2021 that may be closed by this pull request
@evaherrada evaherrada requested a review from dhalbert May 24, 2021 19:08
@dhalbert
Copy link
Contributor

Just confirming this library should be called Adafruit_Board_Toolkit and not Adafruit_CircuitPython_Board_Toolkit, right?

That is correct. This is not code meant to run in CircuitPython, and this library could have more uses than identifying CircuitPython boards in the long run.

Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These must have been left over from an early draft of the library. Thanks for fixing this.

@dhalbert dhalbert merged commit b6690a0 into main May 24, 2021
@dhalbert dhalbert deleted the fix-links branch May 24, 2021 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs sidebar download link is broken
2 participants