Calibration patch for newer AHT20's #16
Conversation
Updating calibration function so that it isn't required to pass for newer AHT20's. This same change was made for the [Arduino library](adafruit/Adafruit_AHTX0#13)
|
Tested with the library example (although with an older AHT20) and ran as expected. Also added |
| self._buf[0] = AHTX0_CMD_CALIBRATE | ||
| self._buf[1] = 0x08 | ||
| self._buf[2] = 0x00 | ||
| with self.i2c_device as i2c: | ||
| i2c.write(self._buf, start=0, end=3) | ||
| while self.status & AHTX0_STATUS_BUSY: | ||
| time.sleep(0.01) | ||
| if not self.status & AHTX0_STATUS_CALIBRATED: |
adafruit_ahtx0.py
Outdated
| @@ -106,16 +106,14 @@ def reset(self) -> None: | |||
| time.sleep(0.02) # 20ms delay to wake up | |||
|
|
|||
| def calibrate(self) -> bool: | |||
| """Ask the sensor to self-calibrate. Returns True on success, False otherwise""" | |||
| """Ask the sensor to self-calibrate. May not 'succeed' on newer AHT20s.""" | |||
| self._buf[0] = AHTX0_CMD_CALIBRATE | |||
| self._buf[1] = 0x08 | |||
| self._buf[2] = 0x00 | |||
| with self.i2c_device as i2c: | |||
| i2c.write(self._buf, start=0, end=3) | |||
There was a problem hiding this comment.
this may fail, so do a try/except pass here
There was a problem hiding this comment.
wrap only the call that can fail, please!
i2c.write(self._buf, start=0, end=3)
There was a problem hiding this comment.
@ladyada ohh okay, will fix. one question though- in __init__ if calibration returns False then it raises a RuntimeError, should that be changed too to not raise an error? or would the sensor read the SENSOR_CALIBRATED bit with the try/except and not return False?
|
👋 Thanks for this pull request! Unfortunately, it looks like the automated continuous integration (CI) test(s) failed. These can be tricky to fix so we've written a guide on how to fix them locally. It has pages about running pre-commit locally and another about building the docs locally with sphinx. Thanks for contributing to CircuitPython! If you have more questions, feel free to join the Adafruit Discord and post in #circuitpython-dev. |
|
@ladyada would you be able to test this with a "new" AHT with the funky behavior? otherwise, LGTM, simple catch all exception pass |
Updating https://github.com/adafruit/Adafruit_CircuitPython_AHTx0 to 1.0.19 from 1.0.18: > Merge pull request adafruit/Adafruit_CircuitPython_AHTx0#16 from adafruit/aht20_calibration > "fix rtd theme " Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Updating calibration function so that it isn't required to pass for newer AHT20's. This same change was made for the Arduino library