Remove forced mode at end of set_heatr_conf #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is an attempt to resolve: #69
I tested this change successfully on a Feather S3 TFT 9.0.3 with an Adafruit BME680 connected via stemma cable. With this change while running the simpletest script the first values printed are no longer wrong and static.
As far as I can tell the readings look reasonably correct to me, but I didn't do any accuracy comparisons against any other known calibrated source. Manipulating temperature, humidity, and gas in the environment the sensor is in appear to change their respective values as expected.
@puterboy , @DL3KB if either of you are able to test this, any additional testing is greatly appreciated.