Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support CPython #18

Merged
merged 1 commit into from
May 16, 2024
Merged

Support CPython #18

merged 1 commit into from
May 16, 2024

Conversation

justmobilize
Copy link
Collaborator

@justmobilize justmobilize commented May 13, 2024 •
edited

This allows you to use ConnectionManager in Cpython:

import adafruit_connection_manager

radio = adafruit_connection_manager.CPythonNetwork()
pool = adafruit_connection_manager.get_radio_socketpool(radio)
ssl_context = adafruit_connection_manager.get_radio_ssl_context(radio)

Allowing libraries to easily support CPython:
image

@justmobilize justmobilize marked this pull request as ready for review May 13, 2024 22:08
@justmobilize
Copy link
Collaborator Author

@dhalbert or @anecdata have a moment to test?

anecdata
anecdata reviewed May 14, 2024
View reviewed changes
Copy link
Member

@anecdata anecdata left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Once I figured out typing, tested (macOS; Python 3.9.1) with a TCP server and a bunch of simultaneous TCP clients (server and clients using this CM code). Everything worked as expected.

@justmobilize
Copy link
Collaborator Author

@dhalbert any concerns on this one?

dhalbert
dhalbert approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I am just behind on reviews :)

@dhalbert dhalbert merged commit b514b44 into adafruit:main May 16, 2024
1 check passed
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request May 16, 2024
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@c89a027)
b946074 
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 8.2.0 from 8.1.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#202 from justmobilize/add-sendto

Updating https://github.com/adafruit/Adafruit_CircuitPython_ConnectionManager to 3.1.0 from 3.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_ConnectionManager#18 from justmobilize/support-cpython
  > Merge pull request adafruit/Adafruit_CircuitPython_ConnectionManager#17 from justmobilize/update-tests

Updating https://github.com/adafruit/Adafruit_CircuitPython_NTP to 3.1.1 from 3.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_NTP#34 from justmobilize/use-sedto

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
@justmobilize justmobilize deleted the support-cpython branch May 21, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anecdata anecdata anecdata left review comments

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@justmobilize @dhalbert @anecdata