Added "cx" and "cy" property to the label to change center of Label

[neoxharsh]

I have added "cx" and "cy" property to the label, such that setting those will move the center of the text rather than the top left corner of the text. My apologies if it is already available.

Eg. for PyPortal

timeDisplay = label.Label(font,text='12:60:60',color=color)
timeDisplay.cx = 160 
timeDisplay.cy = 120

[tannewt]

I like how you are using the Group's x and y to handle this! I'd rather not add separate cx and cy properties though. Instead, I'd like to see one or two properties that set the anchor position. Right how it's fixed as Center Left but you'd like Center Center.

With the anchor property, changes to the bounding box, x, or y (overridden) would trigger changing the Group's x and y.

Thanks!

[kattni]

@neoxharsh Thank you for the contribution! There are a number of linting errors that need addressing, as well as a change request in the comment above. If you're still interested in seeing this included in this library, please make the necessary changes. If you need assistance with any of it, please let us know. Thanks!

[caternuson]

You can avoid creating _anchored_position and shorten this up to something like:

return self.x-self._boundingbox[2]*self._anchor_point[0],
       self.y-self._boundingbox[3]*self._anchor_point[1]

[FoamyGuy]

Ah, I see. Thank you, this way it won't need to create the variable at all.

[FoamyGuy]

Here is an example script that shows usage and testing of the anchor point functionality.

On a PyPortal it will output this to the display:

[FoamyGuy]

@caternuson I am trying to work through the pylint issues. It looks like it's mad that I've used self.x = ... and self.y = ... in the new function and they aren't defined in the init. They would be coming from the super class displayio.Group in this case. I could initialize them to 0 in the init() here to fix the pylint error I think, but I'm not sure if that would cause trouble.

[caternuson]

Hmmm...I think that has to do with the linter not knowing the actual class layout for things from the CP firmware. @tannewt What say you?

[makermelissa]

Perhaps the linter would be happy if you set the x and y to some default value inside of the __init__ function.

[neoxharsh]

@tannewt @kattni @makermelissa @FoamyGuy @caternuson, thanks for all your support. I am on vacation, staying away from tech for a while. 😇

[kattni]

@makermelissa @caternuson @FoamyGuy Did one of you test this iteration? If so, we can merge it. If not, can one of you please test it? Thanks!

[kattni]

@neoxharsh No worries! Thank you for the original contribution! Have a wonderful vacation!

[makermelissa]

@kattni, I did not test. I was merely interpreting the Pylint error.

[caternuson]

@kattni I just tested the linked example above on a PyPortal and it worked as shown. Also ran display_text_simpletest.py example and it continues to work as expected.

@FoamyGuy Do you want to add the example you linked above to the examples folder as part of this PR?

[kattni]

@FoamyGuy Please create a new PR for the example.

@caternuson Thank you for testing! I'll get this merged.

[caternuson]

That'll work. For future ref - you don't even need the parans to return a tuple. Can just do like:

return x, y, z

[kattni]

@FoamyGuy At your convenience, please create a new PR with the example you linked. Please ping me for assistance with naming the example file if it is unclear what it should be named. Thanks!

[FoamyGuy]

@kattni I did test last night with both the simpletest, and the example linked above.

@caternuson I had tried it without the parans first actually. If I understood correct I was getting an Indention error due to that return statement being split across two lines. Explicitly adding the parans seemed to fix the issue for me.

I will make a PR to add the example code today, it'll probably take me a bit to get to, but I'll definitely get it done at some point.

[caternuson]

@FoamyGuy Ah, for multiple lines without parans, may have needed a \ continuation. Something like:

return x, \
       y

No biggie. Mainly just wanted to point out the syntax is possible.

[FoamyGuy]

Ah, I see. Thank you. I appreciate it, I've come a long way with Python, but I'm still not very familiar with some of it's features.

[tannewt]

@caternuson @FoamyGuy I prefer using parens to allow line wraps. I think it's easier to see than the trailing \

[caternuson]

^^ yep. i'd agree. for simple, shorter, one liners, can use other syntax