New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adafruit_bus_device is not a dependency #63

Merged

jposada202020 merged 1 commit into adafruit:main from Neradoc:no-bus-device

Mar 5, 2023

Contributor

Neradoc commented Mar 5, 2023

The bus device library is not a dependency for dotstar, it should not be installed by circup or included by the bundler.


          adafruit_bus_device is not a dependency

8f099f0

jposada202020 approved these changes

View reviewed changes

Contributor

jposada202020 left a comment

Thanks LGTM. Change in the requirements file was introduced in 1.3 when they made the library available in Pypi, not sure why.

jposada202020 merged commit 485d043 into adafruit:main

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request


          Automated update by Adabot (adafruit/adabot@2415fa6)

464d995

Updating https://github.com/adafruit/Adafruit_CircuitPython_DotStar to 2.2.7 from 2.2.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_DotStar#63 from Neradoc/no-bus-device

Updating https://github.com/adafruit/Adafruit_CircuitPython_MPL3115A2 to 2.0.5 from 2.0.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_MPL3115A2#26 from jposada202020/correcting_readings
  > Add upload url to release action
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment