Added support for WPA2 Enterprise, including example code. #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
structure looks good to me! once its linted we can merge :) |
|
That was fast....and disapointing.. Looks like it didn't like the line endings? |
|
try running |
|
One thought I just had... I didin't change the version number in the NINA firmware. I was going to mention something about that, but forgot. The version number in the firmware should probably be rev'd in order to make debugging easier. I could update the example script to contain a message about that new version requirement. And perhaps the README.md could/should contain that requirement. |
|
yep please update the version number too! |
… updated README.rst to recommended checking version dependencies in example code.
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Apr 25, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 1.3.7 from 1.3.5: > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#39 from brentru/update-simpletest > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#38 from cpforbes/add_gpio > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#34 from docmollo/docs_wpa2_enterprise Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 2.1.1 from 2.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#27 from brentru/add-image-http-path > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#26 from DigitalMakerCIC/master
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the CircuiPython code that matches the NINA firmware PR I made yesterday. I've included an example script, as well. I've tested this on a PyPortal and Metro M4, both running CircuitPython 4.0.0-beta.6. I did my best to match the existing style, but I may have not have gotten it right. Let me know if you'd like me to tweak things.