New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating HT16K33 code to work with version 4.0.0 #58
Conversation
Does this change also need to be made in matrix_featherwing.py. Also would it make sense at this point to change these to use 0 - 1.0 instead of 0-15 like the HT16K33 itself is now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, this worked for me. Using the copy under the Adafruit repo I got the crash ValueError: Brightness must be a decimal number in the range: 0.0-1.0
and switching to this version, that went away and now it runs. Tested it using the featherwing_alphanum_simpletest.py
example on a Feather nRF running CircuitPython build 20200321-7e56f6e
with one of these: https://www.adafruit.com/product/3129
Good catch @FoamyGuy. I updated it for the matrix featherwing as well. |
I will test this with matrix featherwing this week and merge once testing is complete. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested successfully with PyGamer and 16x8 matrix featherwing using the fading portion of the simpletest in examples.
Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE to 6.1.1 from 6.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_BLE#76 from dhalbert/start_scan-default Updating https://github.com/adafruit/Adafruit_CircuitPython_FeatherWing to 1.11.0 from 1.10.0: > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#58 from makermelissa/master
The latest release of the HT16K33 library changes the brightness range from 0-15 to 0-1.0. This will make it work with the latest release. It also fixes an issue from a recent update by a community member.