Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating HT16K33 code to work with version 4.0.0 #58

Merged
merged 5 commits into from Apr 3, 2020

Conversation

makermelissa
Copy link
Contributor

The latest release of the HT16K33 library changes the brightness range from 0-15 to 0-1.0. This will make it work with the latest release. It also fixes an issue from a recent update by a community member.

@makermelissa makermelissa requested a review from a team March 10, 2020 15:48
@FoamyGuy
Copy link
Contributor

Does this change also need to be made in matrix_featherwing.py. Also would it make sense at this point to change these to use 0 - 1.0 instead of 0-15 like the HT16K33 itself is now?

Copy link

@AndrewTribble AndrewTribble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this worked for me. Using the copy under the Adafruit repo I got the crash ValueError: Brightness must be a decimal number in the range: 0.0-1.0 and switching to this version, that went away and now it runs. Tested it using the featherwing_alphanum_simpletest.py example on a Feather nRF running CircuitPython build 20200321-7e56f6e with one of these: https://www.adafruit.com/product/3129

@makermelissa
Copy link
Contributor Author

Good catch @FoamyGuy. I updated it for the matrix featherwing as well.

@FoamyGuy FoamyGuy self-assigned this Apr 3, 2020
@FoamyGuy
Copy link
Contributor

FoamyGuy commented Apr 3, 2020

I will test this with matrix featherwing this week and merge once testing is complete.

Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully with PyGamer and 16x8 matrix featherwing using the fading portion of the simpletest in examples.

@FoamyGuy FoamyGuy merged commit b4a3e1f into adafruit:master Apr 3, 2020
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants