added german keyboard layout #46
Conversation
There was a problem hiding this comment.
I think this is a good idea, but I also think that if it were added this way, then you'd have to update both the US and German layout when you want to update the files which isn't ideal. Instead, I think it could be good to have a super class that has the methods for doing everything with the keycodes, and then a class for each layout so it can be imported easily. Let me know if you're up to doing this, otherwise, I'd be more than glad to work on it
|
Hello, I guess this is far beyond my knowledge of Phyton and the micro Phyton in particular. I can follow the idea technology wise but my pull request was not more than a quick "hack" from a usually C# and Powershell programmer. So go ahead and build it in a Python fitting fashion. ;) |
|
@Henry-Jones Sure thing. I was actually just about to get started on that. |
|
One issue is that the current HID is a very tight fit as a frozen library on SAMD21 boards right now; any new code (refactored or not) is probably going to overflow flash. We might consider adding keyboard layouts in separate libraries. A common superclass might be able to fit. |
|
I agree with Dan. I'm closing this PR for now as we cannot add another keyboard layout reasonably in this fashion. Dan created an issue and linked it to this PR. Hopefully someone picks it up - Dylan is away for a bit and will not be able to pick it up anytime soon. @Henry-Jones If you're interested in looking into the suggested solution, please let us know. It sounds like you're not as comfortable in Python as other languages, so I understand if you're not interested. |
No description provided.