Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable user to access body of request #12

Merged
merged 2 commits into from Aug 19, 2022
Merged

enable user to access body of request #12

merged 2 commits into from Aug 19, 2022

Conversation

eirinnm
Copy link
Contributor

@eirinnm eirinnm commented Aug 10, 2022

Unless I'm mistaken, there doesn't appear to be a way to retrieve the content of an incoming request. This PR exposes the raw_request variable in the HTTPRequest object. I added a very basic usage example.

FoamyGuy
FoamyGuy requested changes Aug 15, 2022
View reviewed changes
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @eirinnm!

One small typo I noticed to change, but looks good to me beyond that.

adafruit_httpserver.py Outdated Show resolved Hide resolved
@ladyada ladyada requested a review from FoamyGuy August 17, 2022 01:44
@tekktrik
Copy link
Member

Looks like the typo was fixed, thanks @eirinnm and @FoamyGuy!

@tekktrik tekktrik merged commit ea9a2e0 into adafruit:main Aug 19, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Aug 20, 2022
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@70cf49e)
740c5aa 
Updating https://github.com/adafruit/Adafruit_CircuitPython_FakeRequests to 1.0.10 from 1.0.9:
  > Merge pull request adafruit/Adafruit_CircuitPython_FakeRequests#8 from tcfranks/main
  > Fix version strings in workflow files
  > Update version string

Updating https://github.com/adafruit/Adafruit_CircuitPython_HTTPServer to 0.5.0 from 0.4.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_HTTPServer#12 from eirinnm/main
  > Fix version strings in workflow files
  > Update version string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoamyGuy FoamyGuy Awaiting requested review from FoamyGuy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eirinnm @tekktrik @FoamyGuy