Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change requirements to pypi format #20

Merged
merged 1 commit into from
Jul 14, 2022

Conversation

Neradoc
Copy link
Contributor

@Neradoc Neradoc commented Jul 13, 2022

While pypi doesn't care about - versus _ and letter case, the format used for the minimqtt requirement makes it listed in "external_dependencies" instead of "dependencies" in the bundle's json file, causing potential issues with bundler tools.

Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@tekktrik tekktrik merged commit 282bda8 into adafruit:main Jul 14, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jul 15, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_SGP30 to 3.0.2 from 3.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_SGP30#39 from pandianmn/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_hashlib to 1.4.6 from 1.4.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_hashlib#20 from nicolasff/docs-new-line

Updating https://github.com/adafruit/Adafruit_CircuitPython_Hue to 1.1.10 from 1.1.9:
  > Merge pull request adafruit/Adafruit_CircuitPython_Hue#20 from Neradoc/pypi-requirements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants