Do not let I2CDevice probe for the device #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
May 12, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP9600 to 1.3.0 from 1.2.4: > Merge pull request adafruit/Adafruit_CircuitPython_MCP9600#20 from dhalbert/no-probe > change discord badge > Patch: Replaced discord badge image > Updated gitignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MCP960x does not seem to like zero-length writes, and can NAK when probed with such a write. On
atmel-samd, the write was repeated once immediately if it failed, and for some reason this worked. But on other ports, the write is done just once, and it fails. If the write is repeated a little later, it still fails.So when creating the
adafruit_busdevice.I2CDevice(), ask it not to probe.