Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add exit before rt #40

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Add exit before rt #40

merged 2 commits into from
Jun 10, 2024

Conversation

purepani
Copy link
Contributor

@purepani purepani commented Apr 8, 2024

Adds the exit command suggested in #34

FoamyGuy
FoamyGuy approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks for the fix @purepani!

I don't have one of these sensors to test with, but the code looks correct to me, and I confirmed the noted page in the datasheet does say to issue the EX command.

@FoamyGuy FoamyGuy merged commit 3e8235e into adafruit:main Jun 10, 2024
1 check passed
@purepani
Copy link
Contributor Author

It was a while since I tested it but I at least remember it working off of my fork so it should be fine.

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jun 11, 2024
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@d723e94)
64cda02 
Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP2515 to 1.1.5 from 1.1.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_MCP2515#25 from karlfl/Use_All_Mask_Filter_Pairs

Updating https://github.com/adafruit/Adafruit_CircuitPython_MLX90393 to 2.1.5 from 2.1.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_MLX90393#40 from purepani/add_exit_before_rt

Updating https://github.com/adafruit/Adafruit_CircuitPython_MLX90640 to 1.3.2 from 1.3.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_MLX90640#32 from adafruit/stemma_i2c

Updating https://github.com/adafruit/Adafruit_CircuitPython_AirLift to 1.0.14 from 1.0.13:
  > Merge pull request adafruit/Adafruit_CircuitPython_AirLift#11 from dhalbert/fix-start-wifi

Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 3.1.1 from 3.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#206 from SamantazFox/patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoamyGuy FoamyGuy FoamyGuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@purepani @FoamyGuy