Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Missing Type Annotations #30

Merged
merged 4 commits into from Dec 12, 2022
Merged

Add Missing Type Annotations #30

merged 4 commits into from Dec 12, 2022

Conversation

tcfranks
Copy link
Contributor

@tcfranks tcfranks commented Nov 1, 2022

resolves #26
submitted for review / comment

@tcfranks
Copy link
Contributor Author

tcfranks commented Nov 1, 2022

submitted for review / comment

PS> I think the yield in line 779 should return an Iterator[Tuple[int, int]] but that is breaking the precommits, so maybe not...

@tcfranks
Copy link
Contributor Author

@tekktrik , @FoamyGuy ,
Did I gum this one up somehow with my comment, is it waiting on me, or is it just down in the queue? I slowed down after hactoberfest to let the smoke clear, but I have 3 or 4 more other pr's to submit, but wanted to get this out of the way first.....

Thanks!

@tekktrik
Copy link
Member

Looks like this just fell through the cracks. I'll request a review and try to get to it shortly if no one else does first.

@tekktrik tekktrik requested a review from a team December 12, 2022 15:10
FoamyGuy
FoamyGuy approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @tcfranks!

I don't have the hardware for testing, but don't spot anything during review that would change behavior.

Nothing you did caused the delay, this one just fell through the cracks and tekktrik and I have been getting into some other things lately.

I'm still in the process of making a sweep through open PRs today (with an intermission for the meeting). If you've got others that are waiting on us feel free to ping me on them and I'll bump them up my list for this afternoon.

@FoamyGuy FoamyGuy merged commit 8dc2ba4 into adafruit:main Dec 12, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Dec 13, 2022
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@43c5dc5)
210988f 
Updating https://github.com/adafruit/Adafruit_CircuitPython_MLX90640 to 1.2.14 from 1.2.13:
  > Merge pull request adafruit/Adafruit_CircuitPython_MLX90640#30 from tcfranks/main
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 1.12.16 from 1.12.15:
  > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#70 from BiffoBear/add_typing
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_HTTPServer to 1.0.1 from 1.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_HTTPServer#27 from spovlot/response-header-overwrite
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_Logging to 5.1.0 from 5.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_Logging#44 from vladak/multiple_handlers
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoamyGuy FoamyGuy FoamyGuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Type Annotations
3 participants
@tcfranks @tekktrik @FoamyGuy