Fix invalid get_time calls #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerryneedell
approved these changes
Sep 25, 2019
There was a problem hiding this comment.
Looks good to me -- tested on a grand_central with airlift.
>>>
>>>
>>> import ntp_simpletest
Connecting to AP...
Failed to obtain time, retrying in 5 seconds...
Failed to obtain time, retrying in 5 seconds...
Seconds since Jan 1, 1970: 1569423932 seconds
struct_time(tm_year=2019, tm_mon=9, tm_mday=25, tm_hour=15, tm_min=5, tm_sec=32, tm_wday=2, tm_yday=268, tm_isdst=-1)
It is currently 9/25/2019 at 15:5:32 UTC
>>>
|
@jerryneedell Thanks for testing, merging in. |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Sep 25, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_APDS9960 to 1.2.5 from 1.2.4: > Merge pull request adafruit/Adafruit_CircuitPython_APDS9960#14 from kattni/fix-up Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SSD1306 to 1.1.2 from 1.1.1: > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SSD1306#5 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 2.0.0 from 1.9.3: > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#75 from anecdata/bssid_channel Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1306 to 2.6.6 from 2.6.4: > Merge pull request adafruit/Adafruit_CircuitPython_SSD1306#31 from makermelissa/master > Merge pull request adafruit/Adafruit_CircuitPython_SSD1306#30 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_NTP to 1.0.1 from 1.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_NTP#3 from brentru/fix-overflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a
valid_timeproperty forset_timecalls from user-code to detect error raised by ESP32SPI (adafruit/Adafruit_CircuitPython_ESP32SPI#73)Addresses issue: #2
Tested on
Adafruit CircuitPython 4.1.0 on 2019-08-02; Adafruit Metro M4 Airlift Lite with samd51j19