Added type annotations

[patenaud]

No description provided.

[FoamyGuy]

@patenaud Thanks for working on this!

I'll answer some questions you posted over in the issue here.

the microcontroller.Pin and busio.I2C which are passed as arguments in the OV7670 init were not imported. I added the 2 import statements to quiet the complaint but I'm not sure if this was OK. Please confirm.

adding the new imports for them is the proper thing to do. Those new imports should get put inside of the try block with the typing import as the first one i.e.:

try:
    from typing import List, Optional, Union
    from busio import I2C
    from microcontroller import Pin
except ImportError:
    pass

For the pylint complaints about too many arguments you can supress it with a pylint disable line like this:

# pylint: disable=too-many-arguments

If you add that to the functions it's warning about it will opt them out of the test and continue allowing it to pass.

In this case that's fine because your PR didn't add or change the number of arguments anyway, I'm surprised it hadn't been failing actions previously.

[patenaud]

You're welcome! It's been very educational. :-)
I realized that the pylint comment was there but it was after the arguments. I moved it to before the arguments and that seems to have fixed the issue.

[FoamyGuy]

I've had a look over this and found a few changes I think would be good.

[patenaud]

@FoamyGuy I really appreciate the feedback. I'm sure it took you more time to help me than to just do it.

[FoamyGuy]

Looks good to me. Thanks again @patenaud!

I'm always happy to spend time helping out other folks who are interested in contributing! 😄