Ruff updates #134
Draft
Ruff updates #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jepler
requested changes
Mar 24, 2024
| # SPDX-FileCopyrightText: 2020 Diego Elio Pettenò | ||
| # SPDX-FileCopyrightText: 2024 Justin Myers for Adafruit Industries |
There was a problem hiding this comment.
unless you consider this a complete rewrite, the original author attribution must remain.
There was a problem hiding this comment.
Also, since you are not under contract for this work, you can omit "for Adafruit Industries"
There was a problem hiding this comment.
Can totally update.
Would you actually keep these PRs or just recreate them? I made these so we could look and see what was the right path.
And haven't received a full explanation on when the for Adafruit should be there. In my opinion I'm doing it for Adafruit, whether in contract or not...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.